From 87eb84fddd886936ce6c23faac85dbc24b544592 Mon Sep 17 00:00:00 2001 From: Rhet Turnbull Date: Sat, 18 Apr 2020 23:33:02 -0700 Subject: [PATCH] Updated use of _PHOTOS_4_VERSION, closes #106 --- osxphotos/__main__.py | 8 ++++---- osxphotos/photosdb.py | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/osxphotos/__main__.py b/osxphotos/__main__.py index fe0960b8..4a1f2995 100644 --- a/osxphotos/__main__.py +++ b/osxphotos/__main__.py @@ -18,7 +18,7 @@ from pathvalidate import ( import osxphotos -from ._constants import _EXIF_TOOL_URL, _PHOTOS_5_VERSION, _UNKNOWN_PLACE +from ._constants import _EXIF_TOOL_URL, _PHOTOS_4_VERSION, _UNKNOWN_PLACE from ._version import __version__ from .exiftool import get_exiftool_path from .template import ( @@ -428,7 +428,7 @@ def albums(ctx, cli_obj, db, json_, photos_library): photosdb = osxphotos.PhotosDB(dbfile=db) albums = {"albums": photosdb.albums_as_dict} - if photosdb.db_version >= _PHOTOS_5_VERSION: + if photosdb.db_version > _PHOTOS_4_VERSION: albums["shared albums"] = photosdb.albums_shared_as_dict if json_ or cli_obj.json: @@ -493,7 +493,7 @@ def info(ctx, cli_obj, db, json_, photos_library): not_shared_movies = [p for p in movies if not p.shared] info["movie_count"] = len(not_shared_movies) - if pdb.db_version >= _PHOTOS_5_VERSION: + if pdb.db_version > _PHOTOS_4_VERSION: shared_photos = [p for p in photos if p.shared] info["shared_photo_count"] = len(shared_photos) @@ -508,7 +508,7 @@ def info(ctx, cli_obj, db, json_, photos_library): info["albums_count"] = len(albums) info["albums"] = albums - if pdb.db_version >= _PHOTOS_5_VERSION: + if pdb.db_version > _PHOTOS_4_VERSION: albums_shared = pdb.albums_shared_as_dict info["shared_albums_count"] = len(albums_shared) info["shared_albums"] = albums_shared diff --git a/osxphotos/photosdb.py b/osxphotos/photosdb.py index b30cfd4f..326d56e9 100644 --- a/osxphotos/photosdb.py +++ b/osxphotos/photosdb.py @@ -240,7 +240,7 @@ class PhotosDB: self._db_version = self._get_db_version() # If Photos >= 5, actual data isn't in photos.db but in Photos.sqlite - if int(self._db_version) >= int(_PHOTOS_5_VERSION): + if int(self._db_version) > int(_PHOTOS_4_VERSION): dbpath = pathlib.Path(self._dbfile).parent dbfile = dbpath / "Photos.sqlite" if not _check_file_exists(dbfile): @@ -259,7 +259,7 @@ class PhotosDB: library_path = os.path.dirname(os.path.abspath(dbfile)) (library_path, _) = os.path.split(library_path) # drop /database from path self._library_path = library_path - if int(self._db_version) < int(_PHOTOS_5_VERSION): + if int(self._db_version) <= int(_PHOTOS_4_VERSION): masters_path = os.path.join(library_path, "Masters") self._masters_path = masters_path else: @@ -1878,7 +1878,7 @@ class PhotosDB: # folder with no parent (e.g. shared iCloud folders) return folders - if self._db_version >= _PHOTOS_5_VERSION and parent == self._folder_root_pk: + if self._db_version > _PHOTOS_4_VERSION and parent == self._folder_root_pk: # at the top of the folder hierarchy, we're done return folders