From fc6d7b1cf517ed2fbe7002146152a6d010db58af Mon Sep 17 00:00:00 2001 From: Rhet Turnbull Date: Mon, 11 Nov 2019 21:39:51 -0800 Subject: [PATCH] added comments/TODOs --- osxphotos/__init__.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/osxphotos/__init__.py b/osxphotos/__init__.py index 96c83e5e..f32295b6 100644 --- a/osxphotos/__init__.py +++ b/osxphotos/__init__.py @@ -20,6 +20,7 @@ from . import _applescript # from loguru import logger +# TODO: Add favorites, hidden # TODO: Does not work with Photos 5.0 / Mac OS 10.15 Catalina # TODO: standardize _ and __ as leading char for private variables # TODO: fix docstrings @@ -28,7 +29,8 @@ from . import _applescript # Photos 2.0 (10.12.6) == 2622 # Photos 3.0 (10.13.6) == 3301 # Photos 4.0 (10.14.5) == 4016 -# Photos 4.0 (10.4.6) == 4025 +# Photos 4.0 (10.14.6) == 4025 +# Photos 5.0 (10.15.0) == 6000 # TODO: Should this also use compatibleBackToVersion from LiGlobals? _TESTED_DB_VERSIONS = ["4025", "4016", "3301", "2622"] @@ -318,6 +320,10 @@ class PhotosDB: if int(self.__db_version) >= int(_PHOTOS_5_VERSION): print(f"DEBUG: version is {self.__db_version}") sys.exit() + # TODO: now need to copy Photos.sqlite and replace _db_file + # TODO: What if user passes Photos.sqlite? need to look for the photos.db file + # or just throw error and tell user to pass photos.db + #ZZZ def _process_database(self): global _debug