forked/shlink-web-client
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink-web-client.git synced 2026-03-03 22:31:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removed direct calls between actions without DI

Browse Source
This commit is contained in:
Alejandro Celaya
2019-01-12 23:59:03 +01:00
parent 4f8c7afc76
commit 1aa1d29d97
3 changed files with 33 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/servers/reducers/server.js
View File

@@ -14,23 +14,20 @@ export const listServers = (serversService) => () => ({
servers: serversService.listServers(),
});
// FIXME listServers action should be injected and not directly invoked
export const createServer = (serversService) => (server) => {
export const createServer = (serversService, listServers) => (server) => {
serversService.createServer(server);
return listServers(serversService)();
return listServers();
};
// FIXME listServers action should be injected and not directly invoked
export const deleteServer = (serversService) => (server) => {
export const deleteServer = (serversService, listServers) => (server) => {
serversService.deleteServer(server);
return listServers(serversService)();
return listServers();
};
// FIXME listServers action should be injected and not directly invoked
export const createServers = (serversService) => (servers) => {
export const createServers = (serversService, listServers) => (servers) => {
serversService.createServers(servers);
return listServers(serversService)();
return listServers();
};

6
src/servers/services/provideServices.js
View File

@@ -35,9 +35,9 @@ const provideServices = (bottle, connect, withRouter) => {
// Actions
bottle.serviceFactory('selectServer', selectServer, 'ServersService');
bottle.serviceFactory('createServer', createServer, 'ServersService');
bottle.serviceFactory('createServers', createServers, 'ServersService');
bottle.serviceFactory('deleteServer', deleteServer, 'ServersService');
bottle.serviceFactory('createServer', createServer, 'ServersService', 'listServers');
bottle.serviceFactory('createServers', createServers, 'ServersService', 'listServers');
bottle.serviceFactory('deleteServer', deleteServer, 'ServersService', 'listServers');
bottle.serviceFactory('listServers', listServers, 'ServersService');
bottle.serviceFactory('resetSelectedServer', () => resetSelectedServer);