Replace direct rendering with react testing library by vitest-browser-react

test/__helpers__/setUpTest.tsx

@@ -1,17 +1,20 @@
 import type { ShlinkApiClient } from '@shlinkio/shlink-js-sdk';
 import type { RenderOptions } from '@testing-library/react';
-import { render } from '@testing-library/react';
+import { render as testingLibRender } from '@testing-library/react';
 import { fromPartial } from '@total-typescript/shoehorn';
 import type { PropsWithChildren, ReactElement } from 'react';
 import { Provider } from 'react-redux';
+import { render as vitestRender } from 'vitest-browser-react';
 import { userEvent } from 'vitest/browser';
 import { ContainerProvider } from '../../src/container/context';
 import type { RootState } from '../../src/store';
 import { setUpStore } from '../../src/store';
 
+export const render = vitestRender;
+
 export const renderWithEvents = (element: ReactElement, options?: RenderOptions) => ({
   user: userEvent.setup(),
-  ...render(element, options),
+  ...testingLibRender(element, options),
 });
 
 export type RenderOptionsWithState = Omit<RenderOptions, 'wrapper'> & {

test/common/NotFound.test.tsx

@@ -1,7 +1,7 @@
-import { render, screen } from '@testing-library/react';
 import { MemoryRouter } from 'react-router';
 import { NotFound } from '../../src/common/NotFound';
 import { checkAccessibility } from '../__helpers__/accessibility';
+import { render } from '../__helpers__/setUpTest';
 
 describe('<NotFound />', () => {
   const setUp = (props = {}) =>
@@ -14,15 +14,15 @@ describe('<NotFound />', () => {
   it('passes a11y checks', () => checkAccessibility(setUp()));
 
   it('shows expected error title', async () => {
-    setUp();
-    await expect.element(screen.getByText('Oops! We could not find requested route.')).toBeInTheDocument();
+    const page = await setUp();
+    await expect.element(page.getByText('Oops! We could not find requested route.')).toBeInTheDocument();
   });
 
   it('shows expected error message', async () => {
-    setUp();
+    const page = await setUp();
     await expect
       .element(
-        screen.getByText(
+        page.getByText(
           "Use your browser's back button to navigate to the page you have previously come from, or just press this button.",
         ),
       )
@@ -34,8 +34,8 @@ describe('<NotFound />', () => {
     [{ to: '/foo/bar', children: 'Hello' }, '/foo/bar', 'Hello'],
     [{ to: '/baz-bar', children: <>Foo</> }, '/baz-bar', 'Foo'],
   ])('shows expected link and text', async (props, expectedLink, expectedText) => {
-    setUp(props);
-    const link = screen.getByRole('link');
+    const page = await setUp(props);
+    const link = page.getByRole('link');
 
     await expect.element(link).toHaveAttribute('href', expectedLink);
     await expect.element(link).toHaveTextContent(expectedText);

test/common/ScrollToTop.test.tsx

@@ -1,7 +1,7 @@
-import { render, screen } from '@testing-library/react';
 import { MemoryRouter } from 'react-router';
 import { ScrollToTop } from '../../src/common/ScrollToTop';
 import { checkAccessibility } from '../__helpers__/accessibility';
+import { render } from '../__helpers__/setUpTest.tsx';
 
 describe('<ScrollToTop />', () => {
   const setUp = (children = 'Foo') =>
@@ -14,7 +14,7 @@ describe('<ScrollToTop />', () => {
   it('passes a11y checks', () => checkAccessibility(setUp()));
 
   it.each([['Foobar'], ['Barfoo'], ['Something']])('just renders children', async (children) => {
-    setUp(children);
+    const screen = await setUp(children);
     await expect.element(screen.getByText(children)).toBeInTheDocument();
   });
 });

test/common/ShlinkVersions.test.tsx

@@ -1,9 +1,9 @@
-import { render, screen } from '@testing-library/react';
 import { fromPartial } from '@total-typescript/shoehorn';
 import type { ShlinkVersionsProps } from '../../src/common/ShlinkVersions';
 import { ShlinkVersions } from '../../src/common/ShlinkVersions';
 import type { NonReachableServer, NotFoundServer, ReachableServer } from '../../src/servers/data';
 import { checkAccessibility } from '../__helpers__/accessibility';
+import { render } from '../__helpers__/setUpTest.tsx';
 
 describe('<ShlinkVersions />', () => {
   const setUp = (props: ShlinkVersionsProps) => render(<ShlinkVersions {...props} />);
@@ -20,8 +20,8 @@ describe('<ShlinkVersions />', () => {
   ])(
     'displays expected versions when selected server is reachable',
     async (clientVersion, selectedServer, expectedClientVersion, expectedServerVersion) => {
-      setUp({ clientVersion, selectedServer });
-      const [serverLink, clientLink] = screen.getAllByRole('link');
+      const screen = await setUp({ clientVersion, selectedServer });
+      const [serverLink, clientLink] = screen.getByRole('link').all();
 
       await expect
         .element(serverLink)
@@ -39,8 +39,8 @@ describe('<ShlinkVersions />', () => {
     ['1.2.3', fromPartial<NotFoundServer>({ serverNotFound: true })],
     ['1.2.3', fromPartial<NonReachableServer>({ serverNotReachable: true })],
   ])('displays only client version when selected server is not reachable', async (clientVersion, selectedServer) => {
-    setUp({ clientVersion, selectedServer });
-    const links = screen.getAllByRole('link');
+    const screen = await setUp({ clientVersion, selectedServer });
+    const links = screen.getByRole('link').all();
 
     expect(links).toHaveLength(1);
     await expect

test/common/img/ShlinkLogo.test.tsx

@@ -1,8 +1,8 @@
 import { brandColor } from '@shlinkio/shlink-frontend-kit';
-import { render } from '@testing-library/react';
 import type { ShlinkLogoProps } from '../../../src/common/img/ShlinkLogo';
 import { ShlinkLogo } from '../../../src/common/img/ShlinkLogo';
 import { checkAccessibility } from '../../__helpers__/accessibility';
+import { render } from '../../__helpers__/setUpTest.tsx';
 
 describe('<ShlinkLogo />', () => {
   const setUp = (props: ShlinkLogoProps = {}) => render(<ShlinkLogo {...props} />);
@@ -14,7 +14,7 @@ describe('<ShlinkLogo />', () => {
     ['red', 'red'],
     ['white', 'white'],
   ])('renders expected color', async (color, expectedColor) => {
-    const { container } = setUp({ color });
+    const { container } = await setUp({ color });
     await expect.element(container.querySelector('g')).toHaveAttribute('fill', expectedColor);
   });
 
@@ -23,7 +23,7 @@ describe('<ShlinkLogo />', () => {
     ['foo', 'foo'],
     ['bar', 'bar'],
   ])('renders expected class', async (className, expectedClassName) => {
-    const { container } = setUp({ className });
+    const { container } = await setUp({ className });
 
     if (expectedClassName) {
       await expect.element(container.firstChild as HTMLElement).toHaveAttribute('class', expectedClassName);

test/container/context.test.tsx

@@ -1,6 +1,6 @@
-import { render } from '@testing-library/react';
 import { fromPartial } from '@total-typescript/shoehorn';
 import { ContainerProvider, useDependencies } from '../../src/container/context';
+import { render } from '../__helpers__/setUpTest.tsx';
 
 describe('context', () => {
   describe('useDependencies', () => {
@@ -12,24 +12,24 @@ describe('context', () => {
       return null;
     }
 
-    it('throws when used outside of ContainerProvider', () => {
-      expect(() => render(<TestComponent name="foo" />)).toThrow(
+    it('throws when used outside of ContainerProvider', async () => {
+      await expect(() => render(<TestComponent name="foo" />)).rejects.toThrow(
         'You cannot use "useDependencies" outside of a ContainerProvider',
       );
     });
 
-    it('throws when requested dependency is not found in container', () => {
-      expect(() =>
+    it('throws when requested dependency is not found in container', async () => {
+      await expect(() =>
         render(
           <ContainerProvider value={fromPartial({})}>
             <TestComponent name="foo" />
           </ContainerProvider>,
         ),
-      ).toThrow('Dependency with name "foo" not found in container');
+      ).rejects.toThrow('Dependency with name "foo" not found in container');
     });
 
-    it('gets dependency from container', () => {
-      render(
+    it('gets dependency from container', async () => {
+      await render(
         <ContainerProvider value={fromPartial({ foo: 'the dependency' })}>
           <TestComponent name="foo" />
         </ContainerProvider>,

test/servers/CreateServer.test.tsx

@@ -1,4 +1,4 @@
-import { fireEvent, waitFor } from '@testing-library/react';
+import { fireEvent } from '@testing-library/react';
 import { fromPartial } from '@total-typescript/shoehorn';
 import { createMemoryHistory } from 'history';
 import { Router } from 'react-router';
@@ -97,7 +97,7 @@ describe('<CreateServer />', () => {
 
     fireEvent.submit(page.getByTestId('server-form').element());
 
-    await waitFor(() => expect(page.getByRole('dialog')).toBeInTheDocument());
+    await expect.element(page.getByRole('dialog')).toBeInTheDocument();
     await user.click(page.getByRole('button', { name: 'Discard' }));
 
     expect(history.location.pathname).toEqual('/foo'); // Goes back to first route from history's initialEntries

test/servers/EditServer.test.tsx

@@ -1,4 +1,4 @@
-import { fireEvent, waitFor } from '@testing-library/react';
+import { fireEvent } from '@testing-library/react';
 import { fromPartial } from '@total-typescript/shoehorn';
 import { createMemoryHistory } from 'history';
 import { Router } from 'react-router';
@@ -86,12 +86,10 @@ describe('<EditServer />', () => {
       await user.click(page.getByLabelText('Forward credentials to this server on every request.'));
       fireEvent.submit(page.getByTestId('server-form').element());
 
-      await waitFor(() =>
-        expect(store.getState().servers[defaultSelectedServer.id]).toEqual(
-          expect.objectContaining({
-            forwardCredentials: !forwardCredentials,
-          }),
-        ),
+      expect(store.getState().servers[defaultSelectedServer.id]).toEqual(
+        expect.objectContaining({
+          forwardCredentials: !forwardCredentials,
+        }),
       );
     },
   );

test/servers/ManageServers.test.tsx

@@ -1,4 +1,3 @@
-import { waitFor } from '@testing-library/react';
 import { fromPartial } from '@total-typescript/shoehorn';
 import { MemoryRouter } from 'react-router';
 import { page } from 'vitest/browser';
@@ -44,25 +43,25 @@ describe('<ManageServers />', () => {
       await user.type(page.getByPlaceholder('Search...'), searchTerm);
     };
     // Add one for the header row
-    const expectRows = (amount: number) => expect(page.getByRole('row').elements()).toHaveLength(amount + 1);
+    const expectRows = (amount: number) => expect.poll(() => page.getByRole('row').elements()).toHaveLength(amount + 1);
 
-    expectRows(3);
+    await expectRows(3);
     await expect.element(page.getByText('No servers found.')).not.toBeInTheDocument();
 
     await search('foo');
-    await waitFor(() => expectRows(1));
+    await expectRows(1);
     await expect.element(page.getByText('No servers found.')).not.toBeInTheDocument();
 
     await search('Ba');
-    await waitFor(() => expectRows(2));
+    await expectRows(2);
     await expect.element(page.getByText('No servers found.')).not.toBeInTheDocument();
 
     await search('invalid');
-    await waitFor(() => expectRows(1));
+    await expectRows(1);
     await expect.element(page.getByText('No servers found.')).toBeInTheDocument();
   });
 
-  it.only.each([[createServerMock('foo')], [createServerMock('foo', true)]])(
+  it.each([[createServerMock('foo')], [createServerMock('foo', true)]])(
     'shows different amount of columns if there are at least one auto-connect server',
     async (server) => {
       setUp({ server });

test/servers/ServersListGroup.test.tsx

@@ -1,9 +1,9 @@
-import { render, screen } from '@testing-library/react';
 import { fromPartial } from '@total-typescript/shoehorn';
 import { MemoryRouter } from 'react-router';
 import type { ServerWithId } from '../../src/servers/data';
 import { ServersListGroup } from '../../src/servers/ServersListGroup';
 import { checkAccessibility } from '../__helpers__/accessibility';
+import { render } from '../__helpers__/setUpTest.tsx';
 
 describe('<ServersListGroup />', () => {
   const servers: ServerWithId[] = [fromPartial({ name: 'foo', id: '123' }), fromPartial({ name: 'bar', id: '456' })];
@@ -19,15 +19,15 @@ describe('<ServersListGroup />', () => {
 
   it('passes a11y checks', () => checkAccessibility(setUp()));
 
-  it.each([[servers], [[]]])('shows servers list', (servers) => {
-    setUp({ servers });
+  it.each([[servers], [[]]])('shows servers list', async (servers) => {
+    const screen = await setUp({ servers });
 
-    expect(screen.queryAllByTestId('list')).toHaveLength(servers.length ? 1 : 0);
-    expect(screen.queryAllByRole('link')).toHaveLength(servers.length);
+    expect(screen.getByTestId('list').elements()).toHaveLength(servers.length ? 1 : 0);
+    expect(screen.getByRole('link').elements()).toHaveLength(servers.length);
   });
 
   it.each([[true], [false], [undefined]])('renders proper classes for embedded', async (borderless) => {
-    setUp({ servers, borderless });
+    const screen = await setUp({ servers, borderless });
     const list = screen.getByTestId('list');
 
     if (!borderless) {