mirror of
https://github.com/shlinkio/shlink-web-client.git
synced 2026-03-16 04:23:47 +00:00
Refactor of redux tests to avoid covering RTK implementation details
This commit is contained in:
Alejandro Celaya
@@ -8,14 +8,15 @@ import { formatIsoDate } from '../../../src/utils/helpers/date';
|
||||
import type { DateInterval } from '../../../src/utils/helpers/dateIntervals';
|
||||
import { rangeOf } from '../../../src/utils/utils';
|
||||
import type {
|
||||
DomainVisits } from '../../../src/visits/reducers/domainVisits';
|
||||
DomainVisits, LoadDomainVisits,
|
||||
} from '../../../src/visits/reducers/domainVisits';
|
||||
import {
|
||||
DEFAULT_DOMAIN,
|
||||
domainVisitsReducerCreator,
|
||||
getDomainVisits as getDomainVisitsCreator,
|
||||
} from '../../../src/visits/reducers/domainVisits';
|
||||
import { createNewVisits } from '../../../src/visits/reducers/visitCreation';
|
||||
import type { Visit } from '../../../src/visits/types';
|
||||
import type { CreateVisit, Visit } from '../../../src/visits/types';
|
||||
|
||||
describe('domainVisitsReducer', () => {
|
||||
const now = new Date();
|
||||
@@ -31,22 +32,28 @@ describe('domainVisitsReducer', () => {
|
||||
const buildState = (data: Partial<DomainVisits>) => Mock.of<DomainVisits>(data);
|
||||
|
||||
it('returns loading on GET_DOMAIN_VISITS_START', () => {
|
||||
const { loading } = reducer(buildState({ loading: false }), { type: getDomainVisits.pending.toString() });
|
||||
const { loading } = reducer(
|
||||
buildState({ loading: false }),
|
||||
getDomainVisits.pending('', Mock.all<LoadDomainVisits>()),
|
||||
);
|
||||
expect(loading).toEqual(true);
|
||||
});
|
||||
|
||||
it('returns loadingLarge on GET_DOMAIN_VISITS_LARGE', () => {
|
||||
const { loadingLarge } = reducer(buildState({ loadingLarge: false }), { type: getDomainVisits.large.toString() });
|
||||
const { loadingLarge } = reducer(buildState({ loadingLarge: false }), getDomainVisits.large());
|
||||
expect(loadingLarge).toEqual(true);
|
||||
});
|
||||
|
||||
it('returns cancelLoad on GET_DOMAIN_VISITS_CANCEL', () => {
|
||||
const { cancelLoad } = reducer(buildState({ cancelLoad: false }), { type: cancelGetDomainVisits.toString() });
|
||||
const { cancelLoad } = reducer(buildState({ cancelLoad: false }), cancelGetDomainVisits());
|
||||
expect(cancelLoad).toEqual(true);
|
||||
});
|
||||
|
||||
it('stops loading and returns error on GET_DOMAIN_VISITS_ERROR', () => {
|
||||
const state = reducer(buildState({ loading: true, error: false }), { type: getDomainVisits.rejected.toString() });
|
||||
const state = reducer(
|
||||
buildState({ loading: true, error: false }),
|
||||
getDomainVisits.rejected(null, '', Mock.all<LoadDomainVisits>()),
|
||||
);
|
||||
const { loading, error } = state;
|
||||
|
||||
expect(loading).toEqual(false);
|
||||
@@ -54,11 +61,11 @@ describe('domainVisitsReducer', () => {
|
||||
});
|
||||
|
||||
it('return visits on GET_DOMAIN_VISITS', () => {
|
||||
const actionVisits = [{}, {}];
|
||||
const { loading, error, visits } = reducer(buildState({ loading: true, error: false }), {
|
||||
type: getDomainVisits.fulfilled.toString(),
|
||||
payload: { visits: actionVisits },
|
||||
});
|
||||
const actionVisits = [Mock.all<Visit>(), Mock.all<Visit>()];
|
||||
const { loading, error, visits } = reducer(
|
||||
buildState({ loading: true, error: false }),
|
||||
getDomainVisits.fulfilled({ visits: actionVisits }, '', Mock.all<LoadDomainVisits>()),
|
||||
);
|
||||
|
||||
expect(loading).toEqual(false);
|
||||
expect(error).toEqual(false);
|
||||
@@ -121,25 +128,23 @@ describe('domainVisitsReducer', () => {
|
||||
],
|
||||
])('prepends new visits on CREATE_VISIT', (state, shortUrlDomain, expectedVisits) => {
|
||||
const shortUrl = Mock.of<ShortUrl>({ domain: shortUrlDomain });
|
||||
const { visits } = reducer(buildState({ ...state, visits: visitsMocks }), {
|
||||
type: createNewVisits.toString(),
|
||||
payload: { createdVisits: [{ shortUrl, visit: { date: formatIsoDate(now) ?? undefined } }] },
|
||||
});
|
||||
const { visits } = reducer(buildState({ ...state, visits: visitsMocks }), createNewVisits([
|
||||
Mock.of<CreateVisit>({ shortUrl, visit: { date: formatIsoDate(now) ?? undefined } }),
|
||||
]));
|
||||
|
||||
expect(visits).toHaveLength(expectedVisits);
|
||||
});
|
||||
|
||||
it('returns new progress on GET_DOMAIN_VISITS_PROGRESS_CHANGED', () => {
|
||||
const state = reducer(undefined, { type: getDomainVisits.progressChanged.toString(), payload: 85 });
|
||||
|
||||
expect(state).toEqual(expect.objectContaining({ progress: 85 }));
|
||||
const { progress } = reducer(undefined, getDomainVisits.progressChanged(85));
|
||||
expect(progress).toEqual(85);
|
||||
});
|
||||
|
||||
it('returns fallbackInterval on GET_DOMAIN_VISITS_FALLBACK_TO_INTERVAL', () => {
|
||||
const fallbackInterval: DateInterval = 'last30Days';
|
||||
const state = reducer(
|
||||
undefined,
|
||||
{ type: getDomainVisits.fallbackToInterval.toString(), payload: fallbackInterval },
|
||||
getDomainVisits.fallbackToInterval(fallbackInterval),
|
||||
);
|
||||
|
||||
expect(state).toEqual(expect.objectContaining({ fallbackInterval }));
|
||||
@@ -153,21 +158,6 @@ describe('domainVisitsReducer', () => {
|
||||
});
|
||||
const domain = 'foo.com';
|
||||
|
||||
it('dispatches start and error when promise is rejected', async () => {
|
||||
getDomainVisitsCall.mockRejectedValue(new Error());
|
||||
|
||||
await getDomainVisits({ domain })(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(2);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: getDomainVisits.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
type: getDomainVisits.rejected.toString(),
|
||||
}));
|
||||
expect(getDomainVisitsCall).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it.each([
|
||||
[undefined],
|
||||
[{}],
|
||||
@@ -185,11 +175,7 @@ describe('domainVisitsReducer', () => {
|
||||
await getDomainVisits({ domain, query })(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(2);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: getDomainVisits.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
type: getDomainVisits.fulfilled.toString(),
|
||||
expect(dispatchMock).toHaveBeenLastCalledWith(expect.objectContaining({
|
||||
payload: { visits, domain, query: query ?? {} },
|
||||
}));
|
||||
expect(getDomainVisitsCall).toHaveBeenCalledTimes(1);
|
||||
@@ -198,12 +184,12 @@ describe('domainVisitsReducer', () => {
|
||||
it.each([
|
||||
[
|
||||
[Mock.of<Visit>({ date: formatISO(subDays(now, 20)) })],
|
||||
{ type: getDomainVisits.fallbackToInterval.toString(), payload: 'last30Days' },
|
||||
getDomainVisits.fallbackToInterval('last30Days'),
|
||||
3,
|
||||
],
|
||||
[
|
||||
[Mock.of<Visit>({ date: formatISO(subDays(now, 100)) })],
|
||||
{ type: getDomainVisits.fallbackToInterval.toString(), payload: 'last180Days' },
|
||||
getDomainVisits.fallbackToInterval('last180Days'),
|
||||
3,
|
||||
],
|
||||
[[], expect.objectContaining({ type: getDomainVisits.fulfilled.toString() }), 2],
|
||||
@@ -227,16 +213,8 @@ describe('domainVisitsReducer', () => {
|
||||
await getDomainVisits({ domain, doIntervalFallback: true })(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(expectedDispatchCalls);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: getDomainVisits.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expectedSecondDispatch);
|
||||
expect(getDomainVisitsCall).toHaveBeenCalledTimes(2);
|
||||
});
|
||||
});
|
||||
|
||||
describe('cancelGetDomainVisits', () => {
|
||||
it('just returns the action with proper type', () =>
|
||||
expect(cancelGetDomainVisits()).toEqual(expect.objectContaining({ type: cancelGetDomainVisits.toString() })));
|
||||
});
|
||||
});
|
||||
|
||||
@@ -28,27 +28,24 @@ describe('nonOrphanVisitsReducer', () => {
|
||||
const buildState = (data: Partial<VisitsInfo>) => Mock.of<VisitsInfo>(data);
|
||||
|
||||
it('returns loading on GET_NON_ORPHAN_VISITS_START', () => {
|
||||
const { loading } = reducer(buildState({ loading: false }), { type: getNonOrphanVisits.pending.toString() });
|
||||
const { loading } = reducer(buildState({ loading: false }), getNonOrphanVisits.pending('', {}));
|
||||
expect(loading).toEqual(true);
|
||||
});
|
||||
|
||||
it('returns loadingLarge on GET_NON_ORPHAN_VISITS_LARGE', () => {
|
||||
const { loadingLarge } = reducer(
|
||||
buildState({ loadingLarge: false }),
|
||||
{ type: getNonOrphanVisits.large.toString() },
|
||||
);
|
||||
const { loadingLarge } = reducer(buildState({ loadingLarge: false }), getNonOrphanVisits.large());
|
||||
expect(loadingLarge).toEqual(true);
|
||||
});
|
||||
|
||||
it('returns cancelLoad on GET_NON_ORPHAN_VISITS_CANCEL', () => {
|
||||
const { cancelLoad } = reducer(buildState({ cancelLoad: false }), { type: cancelGetNonOrphanVisits.toString() });
|
||||
const { cancelLoad } = reducer(buildState({ cancelLoad: false }), cancelGetNonOrphanVisits());
|
||||
expect(cancelLoad).toEqual(true);
|
||||
});
|
||||
|
||||
it('stops loading and returns error on GET_NON_ORPHAN_VISITS_ERROR', () => {
|
||||
const { loading, error } = reducer(
|
||||
buildState({ loading: true, error: false }),
|
||||
{ type: getNonOrphanVisits.rejected.toString() },
|
||||
getNonOrphanVisits.rejected(null, '', {}),
|
||||
);
|
||||
|
||||
expect(loading).toEqual(false);
|
||||
@@ -56,11 +53,11 @@ describe('nonOrphanVisitsReducer', () => {
|
||||
});
|
||||
|
||||
it('return visits on GET_NON_ORPHAN_VISITS', () => {
|
||||
const actionVisits = [{}, {}];
|
||||
const { loading, error, visits } = reducer(buildState({ loading: true, error: false }), {
|
||||
type: getNonOrphanVisits.fulfilled.toString(),
|
||||
payload: { visits: actionVisits },
|
||||
});
|
||||
const actionVisits = [Mock.all<Visit>(), Mock.all<Visit>()];
|
||||
const { loading, error, visits } = reducer(
|
||||
buildState({ loading: true, error: false }),
|
||||
getNonOrphanVisits.fulfilled({ visits: actionVisits }, '', {}),
|
||||
);
|
||||
|
||||
expect(loading).toEqual(false);
|
||||
expect(error).toEqual(false);
|
||||
@@ -103,25 +100,19 @@ describe('nonOrphanVisitsReducer', () => {
|
||||
const prevState = buildState({ ...state, visits: visitsMocks });
|
||||
const visit = Mock.of<Visit>({ date: formatIsoDate(now) ?? undefined });
|
||||
|
||||
const { visits } = reducer(prevState, {
|
||||
type: createNewVisits.toString(),
|
||||
payload: { createdVisits: [{ visit }, { visit }] },
|
||||
});
|
||||
const { visits } = reducer(prevState, createNewVisits([{ visit }, { visit }]));
|
||||
|
||||
expect(visits).toHaveLength(expectedVisits);
|
||||
});
|
||||
|
||||
it('returns new progress on GET_NON_ORPHAN_VISITS_PROGRESS_CHANGED', () => {
|
||||
const state = reducer(undefined, { type: getNonOrphanVisits.progressChanged.toString(), payload: 85 });
|
||||
expect(state).toEqual(expect.objectContaining({ progress: 85 }));
|
||||
const { progress } = reducer(undefined, getNonOrphanVisits.progressChanged(85));
|
||||
expect(progress).toEqual(85);
|
||||
});
|
||||
|
||||
it('returns fallbackInterval on GET_NON_ORPHAN_VISITS_FALLBACK_TO_INTERVAL', () => {
|
||||
const fallbackInterval: DateInterval = 'last30Days';
|
||||
const state = reducer(
|
||||
undefined,
|
||||
{ type: getNonOrphanVisits.fallbackToInterval.toString(), payload: fallbackInterval },
|
||||
);
|
||||
const state = reducer(undefined, getNonOrphanVisits.fallbackToInterval(fallbackInterval));
|
||||
|
||||
expect(state).toEqual(expect.objectContaining({ fallbackInterval }));
|
||||
});
|
||||
@@ -135,21 +126,6 @@ describe('nonOrphanVisitsReducer', () => {
|
||||
|
||||
beforeEach(jest.resetAllMocks);
|
||||
|
||||
it('dispatches start and error when promise is rejected', async () => {
|
||||
getNonOrphanVisitsCall.mockRejectedValue({});
|
||||
|
||||
await getNonOrphanVisits({})(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(2);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: getNonOrphanVisits.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
type: getNonOrphanVisits.rejected.toString(),
|
||||
}));
|
||||
expect(getNonOrphanVisitsCall).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it.each([
|
||||
[undefined],
|
||||
[{}],
|
||||
@@ -167,11 +143,7 @@ describe('nonOrphanVisitsReducer', () => {
|
||||
await getNonOrphanVisits({ query })(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(2);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining(
|
||||
{ type: getNonOrphanVisits.pending.toString() },
|
||||
));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
type: getNonOrphanVisits.fulfilled.toString(),
|
||||
expect(dispatchMock).toHaveBeenLastCalledWith(expect.objectContaining({
|
||||
payload: { visits, query: query ?? {} },
|
||||
}));
|
||||
expect(getNonOrphanVisitsCall).toHaveBeenCalledTimes(1);
|
||||
@@ -180,12 +152,12 @@ describe('nonOrphanVisitsReducer', () => {
|
||||
it.each([
|
||||
[
|
||||
[Mock.of<Visit>({ date: formatISO(subDays(now, 5)) })],
|
||||
{ type: getNonOrphanVisits.fallbackToInterval.toString(), payload: 'last7Days' },
|
||||
getNonOrphanVisits.fallbackToInterval('last7Days'),
|
||||
3,
|
||||
],
|
||||
[
|
||||
[Mock.of<Visit>({ date: formatISO(subDays(now, 200)) })],
|
||||
{ type: getNonOrphanVisits.fallbackToInterval.toString(), payload: 'last365Days' },
|
||||
getNonOrphanVisits.fallbackToInterval('last365Days'),
|
||||
3,
|
||||
],
|
||||
[[], expect.objectContaining({ type: getNonOrphanVisits.fulfilled.toString() }), 2],
|
||||
@@ -209,16 +181,8 @@ describe('nonOrphanVisitsReducer', () => {
|
||||
await getNonOrphanVisits({ doIntervalFallback: true })(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(expectedAmountOfDispatches);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: getNonOrphanVisits.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expectedSecondDispatch);
|
||||
expect(getNonOrphanVisitsCall).toHaveBeenCalledTimes(2);
|
||||
});
|
||||
});
|
||||
|
||||
describe('cancelGetNonOrphanVisits', () => {
|
||||
it('just returns the action with proper type', () =>
|
||||
expect(cancelGetNonOrphanVisits()).toEqual({ type: cancelGetNonOrphanVisits.toString() }));
|
||||
});
|
||||
});
|
||||
|
||||
@@ -28,24 +28,24 @@ describe('orphanVisitsReducer', () => {
|
||||
const buildState = (data: Partial<VisitsInfo>) => Mock.of<VisitsInfo>(data);
|
||||
|
||||
it('returns loading on GET_ORPHAN_VISITS_START', () => {
|
||||
const { loading } = reducer(buildState({ loading: false }), { type: getOrphanVisits.pending.toString() });
|
||||
const { loading } = reducer(buildState({ loading: false }), getOrphanVisits.pending('', {}));
|
||||
expect(loading).toEqual(true);
|
||||
});
|
||||
|
||||
it('returns loadingLarge on GET_ORPHAN_VISITS_LARGE', () => {
|
||||
const { loadingLarge } = reducer(buildState({ loadingLarge: false }), { type: getOrphanVisits.large.toString() });
|
||||
const { loadingLarge } = reducer(buildState({ loadingLarge: false }), getOrphanVisits.large());
|
||||
expect(loadingLarge).toEqual(true);
|
||||
});
|
||||
|
||||
it('returns cancelLoad on GET_ORPHAN_VISITS_CANCEL', () => {
|
||||
const { cancelLoad } = reducer(buildState({ cancelLoad: false }), { type: cancelGetOrphanVisits.toString() });
|
||||
const { cancelLoad } = reducer(buildState({ cancelLoad: false }), cancelGetOrphanVisits());
|
||||
expect(cancelLoad).toEqual(true);
|
||||
});
|
||||
|
||||
it('stops loading and returns error on GET_ORPHAN_VISITS_ERROR', () => {
|
||||
const { loading, error } = reducer(
|
||||
buildState({ loading: true, error: false }),
|
||||
{ type: getOrphanVisits.rejected.toString() },
|
||||
getOrphanVisits.rejected(null, '', {}),
|
||||
);
|
||||
|
||||
expect(loading).toEqual(false);
|
||||
@@ -53,11 +53,11 @@ describe('orphanVisitsReducer', () => {
|
||||
});
|
||||
|
||||
it('return visits on GET_ORPHAN_VISITS', () => {
|
||||
const actionVisits = [{}, {}];
|
||||
const { loading, error, visits } = reducer(buildState({ loading: true, error: false }), {
|
||||
type: getOrphanVisits.fulfilled.toString(),
|
||||
payload: { visits: actionVisits },
|
||||
});
|
||||
const actionVisits = [Mock.all<Visit>(), Mock.all<Visit>()];
|
||||
const { loading, error, visits } = reducer(
|
||||
buildState({ loading: true, error: false }),
|
||||
getOrphanVisits.fulfilled({ visits: actionVisits }, '', {}),
|
||||
);
|
||||
|
||||
expect(loading).toEqual(false);
|
||||
expect(error).toEqual(false);
|
||||
@@ -100,25 +100,19 @@ describe('orphanVisitsReducer', () => {
|
||||
const prevState = buildState({ ...state, visits: visitsMocks });
|
||||
const visit = Mock.of<Visit>({ date: formatIsoDate(now) ?? undefined });
|
||||
|
||||
const { visits } = reducer(prevState, {
|
||||
type: createNewVisits.toString(),
|
||||
payload: { createdVisits: [{ visit }, { visit }] },
|
||||
});
|
||||
const { visits } = reducer(prevState, createNewVisits([{ visit }, { visit }]));
|
||||
|
||||
expect(visits).toHaveLength(expectedVisits);
|
||||
});
|
||||
|
||||
it('returns new progress on GET_ORPHAN_VISITS_PROGRESS_CHANGED', () => {
|
||||
const state = reducer(undefined, { type: getOrphanVisits.progressChanged.toString(), payload: 85 });
|
||||
expect(state).toEqual(expect.objectContaining({ progress: 85 }));
|
||||
const { progress } = reducer(undefined, getOrphanVisits.progressChanged(85));
|
||||
expect(progress).toEqual(85);
|
||||
});
|
||||
|
||||
it('returns fallbackInterval on GET_ORPHAN_VISITS_FALLBACK_TO_INTERVAL', () => {
|
||||
const fallbackInterval: DateInterval = 'last30Days';
|
||||
const state = reducer(
|
||||
undefined,
|
||||
{ type: getOrphanVisits.fallbackToInterval.toString(), payload: fallbackInterval },
|
||||
);
|
||||
const state = reducer(undefined, getOrphanVisits.fallbackToInterval(fallbackInterval));
|
||||
|
||||
expect(state).toEqual(expect.objectContaining({ fallbackInterval }));
|
||||
});
|
||||
@@ -130,21 +124,6 @@ describe('orphanVisitsReducer', () => {
|
||||
orphanVisits: { cancelLoad: false },
|
||||
});
|
||||
|
||||
it('dispatches start and error when promise is rejected', async () => {
|
||||
getOrphanVisitsCall.mockRejectedValue({});
|
||||
|
||||
await getOrphanVisits({})(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(2);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: getOrphanVisits.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
type: getOrphanVisits.rejected.toString(),
|
||||
}));
|
||||
expect(getOrphanVisitsCall).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it.each([
|
||||
[undefined],
|
||||
[{}],
|
||||
@@ -162,11 +141,7 @@ describe('orphanVisitsReducer', () => {
|
||||
await getOrphanVisits({ query })(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(2);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: getOrphanVisits.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
type: getOrphanVisits.fulfilled.toString(),
|
||||
expect(dispatchMock).toHaveBeenLastCalledWith(expect.objectContaining({
|
||||
payload: { visits, query: query ?? {} },
|
||||
}));
|
||||
expect(getOrphanVisitsCall).toHaveBeenCalledTimes(1);
|
||||
@@ -175,12 +150,12 @@ describe('orphanVisitsReducer', () => {
|
||||
it.each([
|
||||
[
|
||||
[Mock.of<Visit>({ date: formatISO(subDays(now, 5)) })],
|
||||
{ type: getOrphanVisits.fallbackToInterval.toString(), payload: 'last7Days' },
|
||||
getOrphanVisits.fallbackToInterval('last7Days'),
|
||||
3,
|
||||
],
|
||||
[
|
||||
[Mock.of<Visit>({ date: formatISO(subDays(now, 200)) })],
|
||||
{ type: getOrphanVisits.fallbackToInterval.toString(), payload: 'last365Days' },
|
||||
getOrphanVisits.fallbackToInterval('last365Days'),
|
||||
3,
|
||||
],
|
||||
[[], expect.objectContaining({ type: getOrphanVisits.fulfilled.toString() }), 2],
|
||||
@@ -204,16 +179,8 @@ describe('orphanVisitsReducer', () => {
|
||||
await getOrphanVisits({ doIntervalFallback: true })(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(expectedDispatchCalls);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: getOrphanVisits.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expectedSecondDispatch);
|
||||
expect(getOrphanVisitsCall).toHaveBeenCalledTimes(2);
|
||||
});
|
||||
});
|
||||
|
||||
describe('cancelGetOrphanVisits', () => {
|
||||
it('just returns the action with proper type', () =>
|
||||
expect(cancelGetOrphanVisits()).toEqual({ type: cancelGetOrphanVisits.toString() }));
|
||||
});
|
||||
});
|
||||
|
||||
@@ -13,7 +13,7 @@ import {
|
||||
shortUrlVisitsReducerCreator,
|
||||
} from '../../../src/visits/reducers/shortUrlVisits';
|
||||
import { createNewVisits } from '../../../src/visits/reducers/visitCreation';
|
||||
import type { Visit } from '../../../src/visits/types';
|
||||
import type { CreateVisit, Visit } from '../../../src/visits/types';
|
||||
|
||||
describe('shortUrlVisitsReducer', () => {
|
||||
const now = new Date();
|
||||
@@ -29,27 +29,24 @@ describe('shortUrlVisitsReducer', () => {
|
||||
const buildState = (data: Partial<ShortUrlVisits>) => Mock.of<ShortUrlVisits>(data);
|
||||
|
||||
it('returns loading on GET_SHORT_URL_VISITS_START', () => {
|
||||
const { loading } = reducer(buildState({ loading: false }), { type: getShortUrlVisits.pending.toString() });
|
||||
const { loading } = reducer(buildState({ loading: false }), getShortUrlVisits.pending('', { shortCode: '' }));
|
||||
expect(loading).toEqual(true);
|
||||
});
|
||||
|
||||
it('returns loadingLarge on GET_SHORT_URL_VISITS_LARGE', () => {
|
||||
const { loadingLarge } = reducer(
|
||||
buildState({ loadingLarge: false }),
|
||||
{ type: getShortUrlVisits.large.toString() },
|
||||
);
|
||||
const { loadingLarge } = reducer(buildState({ loadingLarge: false }), getShortUrlVisits.large());
|
||||
expect(loadingLarge).toEqual(true);
|
||||
});
|
||||
|
||||
it('returns cancelLoad on GET_SHORT_URL_VISITS_CANCEL', () => {
|
||||
const { cancelLoad } = reducer(buildState({ cancelLoad: false }), { type: cancelGetShortUrlVisits.toString() });
|
||||
const { cancelLoad } = reducer(buildState({ cancelLoad: false }), cancelGetShortUrlVisits());
|
||||
expect(cancelLoad).toEqual(true);
|
||||
});
|
||||
|
||||
it('stops loading and returns error on GET_SHORT_URL_VISITS_ERROR', () => {
|
||||
const { loading, error } = reducer(
|
||||
buildState({ loading: true, error: false }),
|
||||
{ type: getShortUrlVisits.rejected.toString() },
|
||||
getShortUrlVisits.rejected(null, '', { shortCode: '' }),
|
||||
);
|
||||
|
||||
expect(loading).toEqual(false);
|
||||
@@ -57,11 +54,11 @@ describe('shortUrlVisitsReducer', () => {
|
||||
});
|
||||
|
||||
it('return visits on GET_SHORT_URL_VISITS', () => {
|
||||
const actionVisits = [{}, {}];
|
||||
const { loading, error, visits } = reducer(buildState({ loading: true, error: false }), {
|
||||
type: getShortUrlVisits.fulfilled.toString(),
|
||||
payload: { visits: actionVisits },
|
||||
});
|
||||
const actionVisits = [Mock.all<Visit>(), Mock.all<Visit>()];
|
||||
const { loading, error, visits } = reducer(
|
||||
buildState({ loading: true, error: false }),
|
||||
getShortUrlVisits.fulfilled({ visits: actionVisits }, '', { shortCode: '' }),
|
||||
);
|
||||
|
||||
expect(loading).toEqual(false);
|
||||
expect(error).toEqual(false);
|
||||
@@ -124,25 +121,22 @@ describe('shortUrlVisitsReducer', () => {
|
||||
visits: visitsMocks,
|
||||
});
|
||||
|
||||
const { visits } = reducer(prevState, {
|
||||
type: createNewVisits.toString(),
|
||||
payload: { createdVisits: [{ shortUrl, visit: { date: formatIsoDate(now) ?? undefined } }] },
|
||||
});
|
||||
const { visits } = reducer(
|
||||
prevState,
|
||||
createNewVisits([Mock.of<CreateVisit>({ shortUrl, visit: { date: formatIsoDate(now) ?? undefined } })]),
|
||||
);
|
||||
|
||||
expect(visits).toHaveLength(expectedVisits);
|
||||
});
|
||||
|
||||
it('returns new progress on GET_SHORT_URL_VISITS_PROGRESS_CHANGED', () => {
|
||||
const state = reducer(undefined, { type: getShortUrlVisits.progressChanged.toString(), payload: 85 });
|
||||
expect(state).toEqual(expect.objectContaining({ progress: 85 }));
|
||||
const { progress } = reducer(undefined, getShortUrlVisits.progressChanged(85));
|
||||
expect(progress).toEqual(85);
|
||||
});
|
||||
|
||||
it('returns fallbackInterval on GET_SHORT_URL_VISITS_FALLBACK_TO_INTERVAL', () => {
|
||||
const fallbackInterval: DateInterval = 'last30Days';
|
||||
const state = reducer(
|
||||
undefined,
|
||||
{ type: getShortUrlVisits.fallbackToInterval.toString(), payload: fallbackInterval },
|
||||
);
|
||||
const state = reducer(undefined, getShortUrlVisits.fallbackToInterval(fallbackInterval));
|
||||
|
||||
expect(state).toEqual(expect.objectContaining({ fallbackInterval }));
|
||||
});
|
||||
@@ -154,21 +148,6 @@ describe('shortUrlVisitsReducer', () => {
|
||||
shortUrlVisits: Mock.of<ShortUrlVisits>({ cancelLoad: false }),
|
||||
});
|
||||
|
||||
it('dispatches start and error when promise is rejected', async () => {
|
||||
getShortUrlVisitsCall.mockRejectedValue({});
|
||||
|
||||
await getShortUrlVisits({ shortCode: 'abc123' })(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(2);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: getShortUrlVisits.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
type: getShortUrlVisits.rejected.toString(),
|
||||
}));
|
||||
expect(getShortUrlVisitsCall).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it.each([
|
||||
[undefined, undefined],
|
||||
[{}, undefined],
|
||||
@@ -188,11 +167,7 @@ describe('shortUrlVisitsReducer', () => {
|
||||
await getShortUrlVisits({ shortCode, query })(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(2);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: getShortUrlVisits.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
type: getShortUrlVisits.fulfilled.toString(),
|
||||
expect(dispatchMock).toHaveBeenLastCalledWith(expect.objectContaining({
|
||||
payload: { visits, shortCode, domain, query: query ?? {} },
|
||||
}));
|
||||
expect(getShortUrlVisitsCall).toHaveBeenCalledTimes(1);
|
||||
@@ -223,12 +198,12 @@ describe('shortUrlVisitsReducer', () => {
|
||||
it.each([
|
||||
[
|
||||
[Mock.of<Visit>({ date: formatISO(subDays(now, 5)) })],
|
||||
{ type: getShortUrlVisits.fallbackToInterval.toString(), payload: 'last7Days' },
|
||||
getShortUrlVisits.fallbackToInterval('last7Days'),
|
||||
3,
|
||||
],
|
||||
[
|
||||
[Mock.of<Visit>({ date: formatISO(subDays(now, 200)) })],
|
||||
{ type: getShortUrlVisits.fallbackToInterval.toString(), payload: 'last365Days' },
|
||||
getShortUrlVisits.fallbackToInterval('last365Days'),
|
||||
3,
|
||||
],
|
||||
[[], expect.objectContaining({ type: getShortUrlVisits.fulfilled.toString() }), 2],
|
||||
@@ -252,16 +227,8 @@ describe('shortUrlVisitsReducer', () => {
|
||||
await getShortUrlVisits({ shortCode: 'abc123', doIntervalFallback: true })(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(expectedDispatchCalls);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: getShortUrlVisits.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expectedSecondDispatch);
|
||||
expect(getShortUrlVisitsCall).toHaveBeenCalledTimes(2);
|
||||
});
|
||||
});
|
||||
|
||||
describe('cancelGetShortUrlVisits', () => {
|
||||
it('just returns the action with proper type', () =>
|
||||
expect(cancelGetShortUrlVisits()).toEqual({ type: cancelGetShortUrlVisits.toString() }));
|
||||
});
|
||||
});
|
||||
|
||||
@@ -13,7 +13,7 @@ import {
|
||||
tagVisitsReducerCreator,
|
||||
} from '../../../src/visits/reducers/tagVisits';
|
||||
import { createNewVisits } from '../../../src/visits/reducers/visitCreation';
|
||||
import type { Visit } from '../../../src/visits/types';
|
||||
import type { CreateVisit, Visit } from '../../../src/visits/types';
|
||||
|
||||
describe('tagVisitsReducer', () => {
|
||||
const now = new Date();
|
||||
@@ -29,24 +29,24 @@ describe('tagVisitsReducer', () => {
|
||||
const buildState = (data: Partial<TagVisits>) => Mock.of<TagVisits>(data);
|
||||
|
||||
it('returns loading on GET_TAG_VISITS_START', () => {
|
||||
const { loading } = reducer(buildState({ loading: false }), { type: getTagVisits.pending.toString() });
|
||||
const { loading } = reducer(buildState({ loading: false }), getTagVisits.pending('', { tag: '' }));
|
||||
expect(loading).toEqual(true);
|
||||
});
|
||||
|
||||
it('returns loadingLarge on GET_TAG_VISITS_LARGE', () => {
|
||||
const { loadingLarge } = reducer(buildState({ loadingLarge: false }), { type: getTagVisits.large.toString() });
|
||||
const { loadingLarge } = reducer(buildState({ loadingLarge: false }), getTagVisits.large());
|
||||
expect(loadingLarge).toEqual(true);
|
||||
});
|
||||
|
||||
it('returns cancelLoad on GET_TAG_VISITS_CANCEL', () => {
|
||||
const { cancelLoad } = reducer(buildState({ cancelLoad: false }), { type: cancelGetTagVisits.toString() });
|
||||
const { cancelLoad } = reducer(buildState({ cancelLoad: false }), cancelGetTagVisits());
|
||||
expect(cancelLoad).toEqual(true);
|
||||
});
|
||||
|
||||
it('stops loading and returns error on GET_TAG_VISITS_ERROR', () => {
|
||||
const { loading, error } = reducer(
|
||||
buildState({ loading: true, error: false }),
|
||||
{ type: getTagVisits.rejected.toString() },
|
||||
getTagVisits.rejected(null, '', { tag: '' }),
|
||||
);
|
||||
|
||||
expect(loading).toEqual(false);
|
||||
@@ -54,11 +54,11 @@ describe('tagVisitsReducer', () => {
|
||||
});
|
||||
|
||||
it('return visits on GET_TAG_VISITS', () => {
|
||||
const actionVisits = [{}, {}];
|
||||
const { loading, error, visits } = reducer(buildState({ loading: true, error: false }), {
|
||||
type: getTagVisits.fulfilled.toString(),
|
||||
payload: { visits: actionVisits },
|
||||
});
|
||||
const actionVisits = [Mock.all<Visit>(), Mock.all<Visit>()];
|
||||
const { loading, error, visits } = reducer(
|
||||
buildState({ loading: true, error: false }),
|
||||
getTagVisits.fulfilled({ visits: actionVisits }, '', { tag: '' }),
|
||||
);
|
||||
|
||||
expect(loading).toEqual(false);
|
||||
expect(error).toEqual(false);
|
||||
@@ -121,22 +121,22 @@ describe('tagVisitsReducer', () => {
|
||||
visits: visitsMocks,
|
||||
});
|
||||
|
||||
const { visits } = reducer(prevState, {
|
||||
type: createNewVisits.toString(),
|
||||
payload: { createdVisits: [{ shortUrl, visit: { date: formatIsoDate(now) ?? undefined } }] },
|
||||
});
|
||||
const { visits } = reducer(
|
||||
prevState,
|
||||
createNewVisits([Mock.of<CreateVisit>({ shortUrl, visit: { date: formatIsoDate(now) ?? undefined } })]),
|
||||
);
|
||||
|
||||
expect(visits).toHaveLength(expectedVisits);
|
||||
});
|
||||
|
||||
it('returns new progress on GET_TAG_VISITS_PROGRESS_CHANGED', () => {
|
||||
const state = reducer(undefined, { type: getTagVisits.progressChanged.toString(), payload: 85 });
|
||||
expect(state).toEqual(expect.objectContaining({ progress: 85 }));
|
||||
const { progress } = reducer(undefined, getTagVisits.progressChanged(85));
|
||||
expect(progress).toEqual(85);
|
||||
});
|
||||
|
||||
it('returns fallbackInterval on GET_TAG_VISITS_FALLBACK_TO_INTERVAL', () => {
|
||||
const fallbackInterval: DateInterval = 'last30Days';
|
||||
const state = reducer(undefined, { type: getTagVisits.fallbackToInterval.toString(), payload: fallbackInterval });
|
||||
const state = reducer(undefined, getTagVisits.fallbackToInterval(fallbackInterval));
|
||||
|
||||
expect(state).toEqual(expect.objectContaining({ fallbackInterval }));
|
||||
});
|
||||
@@ -149,21 +149,6 @@ describe('tagVisitsReducer', () => {
|
||||
});
|
||||
const tag = 'foo';
|
||||
|
||||
it('dispatches start and error when promise is rejected', async () => {
|
||||
getTagVisitsCall.mockRejectedValue(new Error());
|
||||
|
||||
await getTagVisits({ tag })(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(2);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: getTagVisits.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
type: getTagVisits.rejected.toString(),
|
||||
}));
|
||||
expect(getTagVisitsCall).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it.each([
|
||||
[undefined],
|
||||
[{}],
|
||||
@@ -181,11 +166,7 @@ describe('tagVisitsReducer', () => {
|
||||
await getTagVisits({ tag, query })(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(2);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: getTagVisits.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
type: getTagVisits.fulfilled.toString(),
|
||||
expect(dispatchMock).toHaveBeenLastCalledWith(expect.objectContaining({
|
||||
payload: { visits, tag, query: query ?? {} },
|
||||
}));
|
||||
expect(getTagVisitsCall).toHaveBeenCalledTimes(1);
|
||||
@@ -194,12 +175,12 @@ describe('tagVisitsReducer', () => {
|
||||
it.each([
|
||||
[
|
||||
[Mock.of<Visit>({ date: formatISO(subDays(now, 20)) })],
|
||||
{ type: getTagVisits.fallbackToInterval.toString(), payload: 'last30Days' },
|
||||
getTagVisits.fallbackToInterval('last30Days'),
|
||||
3,
|
||||
],
|
||||
[
|
||||
[Mock.of<Visit>({ date: formatISO(subDays(now, 100)) })],
|
||||
{ type: getTagVisits.fallbackToInterval.toString(), payload: 'last180Days' },
|
||||
getTagVisits.fallbackToInterval('last180Days'),
|
||||
3,
|
||||
],
|
||||
[[], expect.objectContaining({ type: getTagVisits.fulfilled.toString() }), 2],
|
||||
@@ -223,16 +204,8 @@ describe('tagVisitsReducer', () => {
|
||||
await getTagVisits({ tag, doIntervalFallback: true })(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(expectedDispatchCalls);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: getTagVisits.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expectedSecondDispatch);
|
||||
expect(getTagVisitsCall).toHaveBeenCalledTimes(2);
|
||||
});
|
||||
});
|
||||
|
||||
describe('cancelGetTagVisits', () => {
|
||||
it('just returns the action with proper type', () =>
|
||||
expect(cancelGetTagVisits()).toEqual({ type: cancelGetTagVisits.toString() }));
|
||||
});
|
||||
});
|
||||
|
||||
@@ -9,10 +9,8 @@ describe('visitCreationReducer', () => {
|
||||
const visit = Mock.all<Visit>();
|
||||
|
||||
it('just returns the action with proper type', () => {
|
||||
expect(createNewVisits([{ shortUrl, visit }])).toEqual({
|
||||
type: createNewVisits.toString(),
|
||||
payload: { createdVisits: [{ shortUrl, visit }] },
|
||||
});
|
||||
const { payload } = createNewVisits([{ shortUrl, visit }]);
|
||||
expect(payload).toEqual({ createdVisits: [{ shortUrl, visit }] });
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
@@ -2,11 +2,12 @@ import { Mock } from 'ts-mockery';
|
||||
import type { ShlinkApiClient } from '../../../src/api/services/ShlinkApiClient';
|
||||
import type { ShlinkVisitsOverview } from '../../../src/api/types';
|
||||
import type { ShlinkState } from '../../../src/container/types';
|
||||
import type { CreateVisitsAction } from '../../../src/visits/reducers/visitCreation';
|
||||
import { createNewVisits } from '../../../src/visits/reducers/visitCreation';
|
||||
import type {
|
||||
GetVisitsOverviewAction, ParsedVisitsOverview,
|
||||
PartialVisitsSummary, VisitsOverview } from '../../../src/visits/reducers/visitsOverview';
|
||||
ParsedVisitsOverview,
|
||||
PartialVisitsSummary,
|
||||
VisitsOverview,
|
||||
} from '../../../src/visits/reducers/visitsOverview';
|
||||
import {
|
||||
loadVisitsOverview as loadVisitsOverviewCreator,
|
||||
visitsOverviewReducerCreator,
|
||||
@@ -22,14 +23,12 @@ describe('visitsOverviewReducer', () => {
|
||||
beforeEach(jest.clearAllMocks);
|
||||
|
||||
describe('reducer', () => {
|
||||
const action = (type: string) =>
|
||||
Mock.of<GetVisitsOverviewAction>({ type }) as GetVisitsOverviewAction & CreateVisitsAction;
|
||||
const state = (payload: Partial<VisitsOverview> = {}) => Mock.of<VisitsOverview>(payload);
|
||||
|
||||
it('returns loading on GET_OVERVIEW_START', () => {
|
||||
const { loading } = reducer(
|
||||
state({ loading: false, error: false }),
|
||||
action(loadVisitsOverview.pending.toString()),
|
||||
loadVisitsOverview.pending(''),
|
||||
);
|
||||
|
||||
expect(loading).toEqual(true);
|
||||
@@ -38,7 +37,7 @@ describe('visitsOverviewReducer', () => {
|
||||
it('stops loading and returns error on GET_OVERVIEW_ERROR', () => {
|
||||
const { loading, error } = reducer(
|
||||
state({ loading: true, error: false }),
|
||||
action(loadVisitsOverview.rejected.toString()),
|
||||
loadVisitsOverview.rejected(null, ''),
|
||||
);
|
||||
|
||||
expect(loading).toEqual(false);
|
||||
@@ -145,23 +144,6 @@ describe('visitsOverviewReducer', () => {
|
||||
const dispatchMock = jest.fn();
|
||||
const getState = () => Mock.of<ShlinkState>();
|
||||
|
||||
beforeEach(() => dispatchMock.mockReset());
|
||||
|
||||
it('dispatches start and error when promise is rejected', async () => {
|
||||
getVisitsOverview.mockRejectedValue(undefined);
|
||||
|
||||
await loadVisitsOverview()(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(2);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: loadVisitsOverview.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
type: loadVisitsOverview.rejected.toString(),
|
||||
}));
|
||||
expect(getVisitsOverview).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it.each([
|
||||
[
|
||||
// Shlink <3.5.0
|
||||
@@ -191,13 +173,7 @@ describe('visitsOverviewReducer', () => {
|
||||
await loadVisitsOverview()(dispatchMock, getState, {});
|
||||
|
||||
expect(dispatchMock).toHaveBeenCalledTimes(2);
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
type: loadVisitsOverview.pending.toString(),
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
type: loadVisitsOverview.fulfilled.toString(),
|
||||
payload: dispatchedPayload,
|
||||
}));
|
||||
expect(dispatchMock).toHaveBeenNthCalledWith(2, expect.objectContaining({ payload: dispatchedPayload }));
|
||||
expect(getVisitsOverview).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user