forked/shlink-web-client
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink-web-client.git synced 2026-03-13 02:53:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactored server reducer, removing duplicated code and taking advantage of redux-actions

Browse Source
This commit is contained in:
Alejandro Celaya
2019-03-17 09:06:10 +01:00
parent 724c804971
commit 51b5f6264d
3 changed files with 16 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/servers/reducers/server.test.js
View File

@@ -9,13 +9,13 @@ import reducer, {
} from '../../../src/servers/reducers/server';
describe('serverReducer', () => {
const servers = {
const payload = {
abc123: { id: 'abc123' },
def456: { id: 'def456' },
};
const expectedFetchServersResult = { type: FETCH_SERVERS, servers };
const expectedFetchServersResult = { type: FETCH_SERVERS, payload };
const ServersServiceMock = {
listServers: sinon.fake.returns(servers),
listServers: sinon.fake.returns(payload),
createServer: sinon.fake(),
deleteServer: sinon.fake(),
createServers: sinon.fake(),
@@ -23,7 +23,7 @@ describe('serverReducer', () => {
describe('reducer', () => {
it('returns servers when action is FETCH_SERVERS', () =>
expect(reducer({}, { type: FETCH_SERVERS, servers })).toEqual(servers));
expect(reducer({}, { type: FETCH_SERVERS, payload })).toEqual(payload));
it('returns default when action is unknown', () =>
expect(reducer({}, { type: 'unknown' })).toEqual({}));
@@ -79,7 +79,7 @@ describe('serverReducer', () => {
describe('createServer', () => {
it('creates multiple servers and then fetches servers again', () => {
const serversToCreate = values(servers);
const serversToCreate = values(payload);
const result = createServers(ServersServiceMock, () => expectedFetchServersResult)(serversToCreate);
expect(result).toEqual(expectedFetchServersResult);