diff --git a/src/settings/services/SettingsService.js b/src/settings/services/SettingsService.js deleted file mode 100644 index a3a39446..00000000 --- a/src/settings/services/SettingsService.js +++ /dev/null @@ -1,14 +0,0 @@ -const SETTINGS_STORAGE_KEY = 'settings'; - -export default class SettingsService { - constructor(storage) { - this.storage = storage; - } - - loadSettings = () => this.storage.get(SETTINGS_STORAGE_KEY) || {}; - - updateSettings = (settingsToUpdate) => this.storage.set(SETTINGS_STORAGE_KEY, { - ...this.loadSettings(), - ...settingsToUpdate, - }) -} diff --git a/src/settings/services/provideServices.js b/src/settings/services/provideServices.js index 08ba77d3..1c9e7863 100644 --- a/src/settings/services/provideServices.js +++ b/src/settings/services/provideServices.js @@ -1,7 +1,6 @@ import RealTimeUpdates from '../RealTimeUpdates'; import Settings from '../Settings'; import { setRealTimeUpdates } from '../reducers/settings'; -import SettingsService from './SettingsService'; const provideServices = (bottle, connect) => { // Components @@ -10,9 +9,6 @@ const provideServices = (bottle, connect) => { bottle.serviceFactory('RealTimeUpdates', () => RealTimeUpdates); bottle.decorator('RealTimeUpdates', connect([ 'settings' ], [ 'setRealTimeUpdates' ])); - // Services - bottle.service('SettingsService', SettingsService, 'Storage'); - // Actions bottle.serviceFactory('setRealTimeUpdates', () => setRealTimeUpdates); }; diff --git a/test/settings/services/SettingsService.test.js b/test/settings/services/SettingsService.test.js deleted file mode 100644 index 9e9419db..00000000 --- a/test/settings/services/SettingsService.test.js +++ /dev/null @@ -1,46 +0,0 @@ -import SettingsService from '../../../src/settings/services/SettingsService'; - -describe('SettingsService', () => { - const settings = { foo: 'bar' }; - const createService = (withSettings = true) => { - const storageMock = { - set: jest.fn(), - get: jest.fn(() => withSettings ? settings : undefined), - }; - const service = new SettingsService(storageMock); - - return [ service, storageMock ]; - }; - - afterEach(jest.resetAllMocks); - - describe('loadSettings', () => { - it.each([ - [ false, {}], - [ true, settings ], - ])('returns result if found in storage', (withSettings, expectedResult) => { - const [ service, storageMock ] = createService(withSettings); - - const result = service.loadSettings(); - - expect(result).toEqual(expectedResult); - expect(storageMock.get).toHaveBeenCalledTimes(1); - expect(storageMock.set).not.toHaveBeenCalled(); - }); - }); - - describe('updateSettings', () => { - it.each([ - [ false, { hi: 'goodbye' }, { hi: 'goodbye' }], - [ true, { hi: 'goodbye' }, { foo: 'bar', hi: 'goodbye' }], - [ true, { foo: 'goodbye' }, { foo: 'goodbye' }], - ])('appends provided data to existing settings', (withSettings, settingsToUpdate, expectedResult) => { - const [ service, storageMock ] = createService(withSettings); - - service.updateSettings(settingsToUpdate); - - expect(storageMock.get).toHaveBeenCalledTimes(1); - expect(storageMock.set).toHaveBeenCalledWith(expect.anything(), expectedResult); - }); - }); -});