Created single reducer to handle settings

This commit is contained in:
Alejandro Celaya
2020-04-26 13:00:23 +02:00
parent 3953e98a77
commit bbc47b387e
11 changed files with 40 additions and 32 deletions

View File

@@ -2,34 +2,35 @@ import reducer, {
LOAD_REAL_TIME_UPDATES,
loadRealTimeUpdates,
setRealTimeUpdates,
} from '../../../src/settings/reducers/realTimeUpdates';
} from '../../../src/settings/reducers/settings';
describe('realTimeUpdatesReducer', () => {
describe('settingsReducer', () => {
const SettingsServiceMock = {
updateSettings: jest.fn(),
loadSettings: jest.fn(),
};
const realTimeUpdates = { enabled: true };
afterEach(jest.clearAllMocks);
describe('reducer', () => {
it('returns realTimeUpdates when action is LOAD_REAL_TIME_UPDATES', () => {
expect(reducer({}, { type: LOAD_REAL_TIME_UPDATES, enabled: true })).toEqual({ enabled: true });
expect(reducer({}, { type: LOAD_REAL_TIME_UPDATES, realTimeUpdates })).toEqual({ realTimeUpdates });
});
});
describe('loadRealTimeUpdates', () => {
it.each([
[{}, true ],
[{ realTimeUpdates: {} }, true ],
[{ realTimeUpdates: { enabled: true } }, true ],
[{ realTimeUpdates: { enabled: false } }, false ],
])('loads settings and returns LOAD_REAL_TIME_UPDATES action', (loadedSettings, expectedEnabled) => {
SettingsServiceMock.loadSettings.mockReturnValue(loadedSettings);
it.each([[ true ], [ false ]])('loads settings and returns LOAD_REAL_TIME_UPDATES action', (enabled) => {
const realTimeUpdates = { enabled };
SettingsServiceMock.loadSettings.mockReturnValue({ realTimeUpdates });
const result = loadRealTimeUpdates(SettingsServiceMock)();
expect(result).toEqual({ type: LOAD_REAL_TIME_UPDATES, enabled: expectedEnabled });
expect(result).toEqual({
type: LOAD_REAL_TIME_UPDATES,
realTimeUpdates,
});
expect(SettingsServiceMock.loadSettings).toHaveBeenCalled();
});
});

View File

@@ -9,6 +9,7 @@ describe('<ShortUrlsList />', () => {
const ShortUrlsRow = () => '';
const listShortUrlsMock = jest.fn();
const resetShortUrlParamsMock = jest.fn();
const realTimeUpdates = { enabled: true };
const ShortUrlsList = shortUrlsListCreator(ShortUrlsRow);
@@ -37,6 +38,7 @@ describe('<ShortUrlsList />', () => {
]
}
mercureInfo={{ loading: true }}
settings={{ realTimeUpdates }}
/>
);
});

View File

@@ -21,6 +21,7 @@ describe('<ShortUrlVisits />', () => {
const history = {
goBack: jest.fn(),
};
const realTimeUpdates = { enabled: true };
const createComponent = (shortUrlVisits) => {
const ShortUrlVisits = createShortUrlVisits({ processStatsFromVisits, normalizeVisits: identity }, () => '');
@@ -36,6 +37,7 @@ describe('<ShortUrlVisits />', () => {
shortUrlDetail={{}}
cancelGetShortUrlVisits={identity}
matchMedia={() => ({ matches: false })}
settings={{ realTimeUpdates }}
/>
);