diff --git a/src/servers/reducers/selectedServer.js b/src/servers/reducers/selectedServer.js index f683fbe7..29dfb4e9 100644 --- a/src/servers/reducers/selectedServer.js +++ b/src/servers/reducers/selectedServer.js @@ -19,7 +19,7 @@ export const selectServer = ({ findServerById }, buildShlinkApiClient) => (serve dispatch(resetShortUrlParams()); const selectedServer = findServerById(serverId); - const { health } = await buildShlinkApiClient(selectedServer); + const { health } = buildShlinkApiClient(selectedServer); const version = await health() .then(({ version }) => version === LATEST_VERSION_CONSTRAINT ? MAX_FALLBACK_VERSION : version) .then((version) => !versionIsValidSemVer(version) ? MIN_FALLBACK_VERSION : version) diff --git a/src/short-urls/reducers/shortUrlCreation.js b/src/short-urls/reducers/shortUrlCreation.js index 0b56938a..dc99e0ac 100644 --- a/src/short-urls/reducers/shortUrlCreation.js +++ b/src/short-urls/reducers/shortUrlCreation.js @@ -31,7 +31,7 @@ export default handleActions({ export const createShortUrl = (buildShlinkApiClient) => (data) => async (dispatch, getState) => { dispatch({ type: CREATE_SHORT_URL_START }); - const { createShortUrl } = await buildShlinkApiClient(getState); + const { createShortUrl } = buildShlinkApiClient(getState); try { const result = await createShortUrl(data); diff --git a/src/short-urls/reducers/shortUrlDeletion.js b/src/short-urls/reducers/shortUrlDeletion.js index cc10dc64..a878d07f 100644 --- a/src/short-urls/reducers/shortUrlDeletion.js +++ b/src/short-urls/reducers/shortUrlDeletion.js @@ -32,7 +32,7 @@ export default handleActions({ export const deleteShortUrl = (buildShlinkApiClient) => (shortCode, domain) => async (dispatch, getState) => { dispatch({ type: DELETE_SHORT_URL_START }); - const { deleteShortUrl } = await buildShlinkApiClient(getState); + const { deleteShortUrl } = buildShlinkApiClient(getState); try { await deleteShortUrl(shortCode, domain); diff --git a/src/short-urls/reducers/shortUrlMeta.js b/src/short-urls/reducers/shortUrlMeta.js index c05bf4ba..7582414f 100644 --- a/src/short-urls/reducers/shortUrlMeta.js +++ b/src/short-urls/reducers/shortUrlMeta.js @@ -37,7 +37,7 @@ export default handleActions({ export const editShortUrlMeta = (buildShlinkApiClient) => (shortCode, domain, meta) => async (dispatch, getState) => { dispatch({ type: EDIT_SHORT_URL_META_START }); - const { updateShortUrlMeta } = await buildShlinkApiClient(getState); + const { updateShortUrlMeta } = buildShlinkApiClient(getState); try { await updateShortUrlMeta(shortCode, domain, meta); diff --git a/src/short-urls/reducers/shortUrlTags.js b/src/short-urls/reducers/shortUrlTags.js index c48e2e03..46c91d54 100644 --- a/src/short-urls/reducers/shortUrlTags.js +++ b/src/short-urls/reducers/shortUrlTags.js @@ -31,7 +31,7 @@ export default handleActions({ export const editShortUrlTags = (buildShlinkApiClient) => (shortCode, domain, tags) => async (dispatch, getState) => { dispatch({ type: EDIT_SHORT_URL_TAGS_START }); - const { updateShortUrlTags } = await buildShlinkApiClient(getState); + const { updateShortUrlTags } = buildShlinkApiClient(getState); try { const normalizedTags = await updateShortUrlTags(shortCode, domain, tags); diff --git a/src/short-urls/reducers/shortUrlsList.js b/src/short-urls/reducers/shortUrlsList.js index 48bd3d78..efd8978b 100644 --- a/src/short-urls/reducers/shortUrlsList.js +++ b/src/short-urls/reducers/shortUrlsList.js @@ -58,7 +58,7 @@ export default handleActions({ export const listShortUrls = (buildShlinkApiClient) => (params = {}) => async (dispatch, getState) => { dispatch({ type: LIST_SHORT_URLS_START }); - const { listShortUrls } = await buildShlinkApiClient(getState); + const { listShortUrls } = buildShlinkApiClient(getState); try { const shortUrls = await listShortUrls(params); diff --git a/src/tags/reducers/tagDelete.js b/src/tags/reducers/tagDelete.js index b682b98f..14486bea 100644 --- a/src/tags/reducers/tagDelete.js +++ b/src/tags/reducers/tagDelete.js @@ -26,7 +26,7 @@ export default handleActions({ export const deleteTag = (buildShlinkApiClient) => (tag) => async (dispatch, getState) => { dispatch({ type: DELETE_TAG_START }); - const { deleteTags } = await buildShlinkApiClient(getState); + const { deleteTags } = buildShlinkApiClient(getState); try { await deleteTags([ tag ]); diff --git a/src/tags/reducers/tagEdit.js b/src/tags/reducers/tagEdit.js index c49da4e9..095d87a0 100644 --- a/src/tags/reducers/tagEdit.js +++ b/src/tags/reducers/tagEdit.js @@ -31,7 +31,7 @@ export const editTag = (buildShlinkApiClient, colorGenerator) => (oldName, newNa getState ) => { dispatch({ type: EDIT_TAG_START }); - const { editTag } = await buildShlinkApiClient(getState); + const { editTag } = buildShlinkApiClient(getState); try { await editTag(oldName, newName); diff --git a/src/tags/reducers/tagsList.js b/src/tags/reducers/tagsList.js index 684a64d3..6cb2ff49 100644 --- a/src/tags/reducers/tagsList.js +++ b/src/tags/reducers/tagsList.js @@ -50,7 +50,7 @@ export const listTags = (buildShlinkApiClient, force = true) => () => async (dis dispatch({ type: LIST_TAGS_START }); try { - const { listTags } = await buildShlinkApiClient(getState); + const { listTags } = buildShlinkApiClient(getState); const tags = await listTags(); dispatch({ tags, type: LIST_TAGS }); diff --git a/src/utils/services/ShlinkApiClientBuilder.js b/src/utils/services/ShlinkApiClientBuilder.js index a7bf3e50..a436f698 100644 --- a/src/utils/services/ShlinkApiClientBuilder.js +++ b/src/utils/services/ShlinkApiClientBuilder.js @@ -8,7 +8,7 @@ const getSelectedServerFromState = (getState) => { return selectedServer; }; -const buildShlinkApiClient = (axios) => async (getStateOrSelectedServer) => { +const buildShlinkApiClient = (axios) => (getStateOrSelectedServer) => { const { url, apiKey } = typeof getStateOrSelectedServer === 'function' ? getSelectedServerFromState(getStateOrSelectedServer) : getStateOrSelectedServer; diff --git a/src/visits/reducers/shortUrlDetail.js b/src/visits/reducers/shortUrlDetail.js index 1a81a736..477464f5 100644 --- a/src/visits/reducers/shortUrlDetail.js +++ b/src/visits/reducers/shortUrlDetail.js @@ -28,7 +28,7 @@ export default handleActions({ export const getShortUrlDetail = (buildShlinkApiClient) => (shortCode, domain) => async (dispatch, getState) => { dispatch({ type: GET_SHORT_URL_DETAIL_START }); - const { getShortUrl } = await buildShlinkApiClient(getState); + const { getShortUrl } = buildShlinkApiClient(getState); try { const shortUrl = await getShortUrl(shortCode, domain); diff --git a/src/visits/reducers/shortUrlVisits.js b/src/visits/reducers/shortUrlVisits.js index 53e16c89..ac6b2dd5 100644 --- a/src/visits/reducers/shortUrlVisits.js +++ b/src/visits/reducers/shortUrlVisits.js @@ -51,7 +51,7 @@ export default handleActions({ export const getShortUrlVisits = (buildShlinkApiClient) => (shortCode, query) => async (dispatch, getState) => { dispatch({ type: GET_SHORT_URL_VISITS_START }); - const { getShortUrlVisits } = await buildShlinkApiClient(getState); + const { getShortUrlVisits } = buildShlinkApiClient(getState); const itemsPerPage = 5000; const isLastPage = ({ currentPage, pagesCount }) => currentPage >= pagesCount; diff --git a/test/servers/reducers/selectedServer.test.js b/test/servers/reducers/selectedServer.test.js index f7650f69..4d20fb5c 100644 --- a/test/servers/reducers/selectedServer.test.js +++ b/test/servers/reducers/selectedServer.test.js @@ -38,7 +38,7 @@ describe('selectedServerReducer', () => { const apiClientMock = { health: jest.fn(), }; - const buildApiClient = jest.fn().mockResolvedValue(apiClientMock); + const buildApiClient = jest.fn().mockReturnValue(apiClientMock); const dispatch = jest.fn(); afterEach(jest.clearAllMocks); diff --git a/test/short-urls/reducers/shortUrlMeta.test.js b/test/short-urls/reducers/shortUrlMeta.test.js index 8775d22d..a02b385a 100644 --- a/test/short-urls/reducers/shortUrlMeta.test.js +++ b/test/short-urls/reducers/shortUrlMeta.test.js @@ -51,7 +51,7 @@ describe('shortUrlMetaReducer', () => { describe('editShortUrlMeta', () => { const updateShortUrlMeta = jest.fn().mockResolvedValue({}); - const buildShlinkApiClient = jest.fn().mockResolvedValue({ updateShortUrlMeta }); + const buildShlinkApiClient = jest.fn().mockReturnValue({ updateShortUrlMeta }); const dispatch = jest.fn(); afterEach(jest.clearAllMocks); diff --git a/test/short-urls/reducers/shortUrlTags.test.js b/test/short-urls/reducers/shortUrlTags.test.js index 967953c8..98bd13a7 100644 --- a/test/short-urls/reducers/shortUrlTags.test.js +++ b/test/short-urls/reducers/shortUrlTags.test.js @@ -51,14 +51,10 @@ describe('shortUrlTagsReducer', () => { describe('editShortUrlTags', () => { const updateShortUrlTags = jest.fn(); - const buildShlinkApiClient = jest.fn().mockResolvedValue({ updateShortUrlTags }); + const buildShlinkApiClient = jest.fn().mockReturnValue({ updateShortUrlTags }); const dispatch = jest.fn(); - afterEach(() => { - updateShortUrlTags.mockReset(); - buildShlinkApiClient.mockClear(); - dispatch.mockReset(); - }); + afterEach(jest.clearAllMocks); it.each([[ undefined ], [ null ], [ 'example.com' ]])('dispatches normalized tags on success', async (domain) => { const normalizedTags = [ 'bar', 'foo' ]; diff --git a/test/tags/reducers/tagsList.test.js b/test/tags/reducers/tagsList.test.js index cd64c151..7cede265 100644 --- a/test/tags/reducers/tagsList.test.js +++ b/test/tags/reducers/tagsList.test.js @@ -104,7 +104,7 @@ describe('tagsListReducer', () => { const tags = [ 'foo', 'bar', 'baz' ]; listTagsMock.mockResolvedValue(tags); - buildShlinkApiClient.mockResolvedValue({ listTags: listTagsMock }); + buildShlinkApiClient.mockReturnValue({ listTags: listTagsMock }); await listTags(buildShlinkApiClient, true)()(dispatch, getState); @@ -127,7 +127,7 @@ describe('tagsListReducer', () => { it('dispatches error when error occurs on list call', async () => { listTagsMock.mockRejectedValue(new Error()); - buildShlinkApiClient.mockResolvedValue({ listTags: listTagsMock }); + buildShlinkApiClient.mockReturnValue({ listTags: listTagsMock }); await assertErrorResult(); @@ -135,7 +135,9 @@ describe('tagsListReducer', () => { }); it('dispatches error when error occurs on build call', async () => { - buildShlinkApiClient.mockRejectedValue(new Error()); + buildShlinkApiClient.mockImplementation(() => { + throw new Error(); + }); await assertErrorResult(); diff --git a/test/utils/services/ShlinkApiClientBuilder.test.js b/test/utils/services/ShlinkApiClientBuilder.test.js index 74ee7df6..2490ca27 100644 --- a/test/utils/services/ShlinkApiClientBuilder.test.js +++ b/test/utils/services/ShlinkApiClientBuilder.test.js @@ -34,10 +34,10 @@ describe('ShlinkApiClientBuilder', () => { expect(secondApiClient).toBe(thirdApiClient); }); - it('does not fetch from state when provided param is already selected server', async () => { + it('does not fetch from state when provided param is already selected server', () => { const url = 'url'; const apiKey = 'apiKey'; - const apiClient = await buildShlinkApiClient({})({ url, apiKey }); + const apiClient = buildShlinkApiClient({})({ url, apiKey }); expect(apiClient._baseUrl).toEqual(url); expect(apiClient._apiKey).toEqual(apiKey);