Created component to edit existing servers

test/servers/reducers/server.test.js

@@ -4,7 +4,7 @@ import reducer, {
   deleteServer,
   listServers,
   createServers,
-  FETCH_SERVERS, FETCH_SERVERS_START,
+  FETCH_SERVERS, FETCH_SERVERS_START, editServer,
 } from '../../../src/servers/reducers/server';
 
 describe('serverReducer', () => {
@@ -16,6 +16,7 @@ describe('serverReducer', () => {
   const ServersServiceMock = {
     listServers: jest.fn(() => list),
     createServer: jest.fn(),
+    editServer: jest.fn(),
     deleteServer: jest.fn(),
     createServers: jest.fn(),
   };
@@ -41,6 +42,7 @@ describe('serverReducer', () => {
         expect(dispatch).toHaveBeenNthCalledWith(2, expectedFetchServersResult);
         expect(ServersServiceMock.listServers).toHaveBeenCalledTimes(1);
         expect(ServersServiceMock.createServer).not.toHaveBeenCalled();
+        expect(ServersServiceMock.editServer).not.toHaveBeenCalled();
         expect(ServersServiceMock.deleteServer).not.toHaveBeenCalled();
         expect(ServersServiceMock.createServers).not.toHaveBeenCalled();
         expect(axios.get).not.toHaveBeenCalled();
@@ -91,6 +93,7 @@ describe('serverReducer', () => {
         expect(dispatch).toHaveBeenNthCalledWith(2, { type: FETCH_SERVERS, list: expectedList });
         expect(NoListServersServiceMock.listServers).toHaveBeenCalledTimes(1);
         expect(NoListServersServiceMock.createServer).not.toHaveBeenCalled();
+        expect(NoListServersServiceMock.editServer).not.toHaveBeenCalled();
         expect(NoListServersServiceMock.deleteServer).not.toHaveBeenCalled();
         expect(NoListServersServiceMock.createServers).toHaveBeenCalledTimes(1);
         expect(axios.get).toHaveBeenCalledTimes(1);
@@ -103,9 +106,25 @@ describe('serverReducer', () => {
         const result = createServer(ServersServiceMock, () => expectedFetchServersResult)(serverToCreate);
 
         expect(result).toEqual(expectedFetchServersResult);
+        expect(ServersServiceMock.listServers).not.toHaveBeenCalled();
         expect(ServersServiceMock.createServer).toHaveBeenCalledTimes(1);
         expect(ServersServiceMock.createServer).toHaveBeenCalledWith(serverToCreate);
+        expect(ServersServiceMock.editServer).not.toHaveBeenCalled();
+        expect(ServersServiceMock.deleteServer).not.toHaveBeenCalled();
+        expect(ServersServiceMock.createServers).not.toHaveBeenCalled();
+      });
+    });
+
+    describe('editServer', () => {
+      it('edits existing server and then fetches servers again', () => {
+        const serverToEdit = { name: 'edited' };
+        const result = editServer(ServersServiceMock, () => expectedFetchServersResult)('123', serverToEdit);
+
+        expect(result).toEqual(expectedFetchServersResult);
         expect(ServersServiceMock.listServers).not.toHaveBeenCalled();
+        expect(ServersServiceMock.createServer).not.toHaveBeenCalled();
+        expect(ServersServiceMock.editServer).toHaveBeenCalledTimes(1);
+        expect(ServersServiceMock.editServer).toHaveBeenCalledWith('123', serverToEdit);
         expect(ServersServiceMock.deleteServer).not.toHaveBeenCalled();
         expect(ServersServiceMock.createServers).not.toHaveBeenCalled();
       });
@@ -120,12 +139,13 @@ describe('serverReducer', () => {
         expect(ServersServiceMock.listServers).not.toHaveBeenCalled();
         expect(ServersServiceMock.createServer).not.toHaveBeenCalled();
         expect(ServersServiceMock.createServers).not.toHaveBeenCalled();
+        expect(ServersServiceMock.editServer).not.toHaveBeenCalled();
         expect(ServersServiceMock.deleteServer).toHaveBeenCalledTimes(1);
         expect(ServersServiceMock.deleteServer).toHaveBeenCalledWith(serverToDelete);
       });
     });
 
-    describe('createServer', () => {
+    describe('createServers', () => {
       it('creates multiple servers and then fetches servers again', () => {
         const serversToCreate = values(list);
         const result = createServers(ServersServiceMock, () => expectedFetchServersResult)(serversToCreate);
@@ -133,9 +153,10 @@ describe('serverReducer', () => {
         expect(result).toEqual(expectedFetchServersResult);
         expect(ServersServiceMock.listServers).not.toHaveBeenCalled();
         expect(ServersServiceMock.createServer).not.toHaveBeenCalled();
+        expect(ServersServiceMock.editServer).not.toHaveBeenCalled();
+        expect(ServersServiceMock.deleteServer).not.toHaveBeenCalled();
         expect(ServersServiceMock.createServers).toHaveBeenCalledTimes(1);
         expect(ServersServiceMock.createServers).toHaveBeenCalledWith(serversToCreate);
-        expect(ServersServiceMock.deleteServer).not.toHaveBeenCalled();
       });
     });
   });

test/servers/services/ServersService.test.js

@@ -5,15 +5,19 @@ describe('ServersService', () => {
     abc123: { id: 'abc123' },
     def456: { id: 'def456' },
   };
-  const createStorageMock = (returnValue) => ({
-    set: jest.fn(),
-    get: jest.fn(() => returnValue),
-  });
+  const createService = (withServers = true) => {
+    const storageMock = {
+      set: jest.fn(),
+      get: jest.fn(() => withServers ? servers : undefined),
+    };
+    const service = new ServersService(storageMock);
+
+    return [ service, storageMock ];
+  };
 
   describe('listServers', () => {
     it('returns an empty object when servers are not found in storage', () => {
-      const storageMock = createStorageMock();
-      const service = new ServersService(storageMock);
+      const [ service, storageMock ] = createService(false);
 
       const result = service.listServers();
 
@@ -23,8 +27,7 @@ describe('ServersService', () => {
     });
 
     it('returns value from storage when found', () => {
-      const storageMock = createStorageMock(servers);
-      const service = new ServersService(storageMock);
+      const [ service, storageMock ] = createService();
 
       const result = service.listServers();
 
@@ -36,8 +39,7 @@ describe('ServersService', () => {
 
   describe('findServerById', () => {
     it('returns undefined when requested server is not found', () => {
-      const storageMock = createStorageMock(servers);
-      const service = new ServersService(storageMock);
+      const [ service, storageMock ] = createService();
 
       const result = service.findServerById('ghi789');
 
@@ -47,8 +49,7 @@ describe('ServersService', () => {
     });
 
     it('returns server from list when found', () => {
-      const storageMock = createStorageMock(servers);
-      const service = new ServersService(storageMock);
+      const [ service, storageMock ] = createService();
 
       const result = service.findServerById('abc123');
 
@@ -60,8 +61,7 @@ describe('ServersService', () => {
 
   describe('createServer', () => {
     it('adds one server to the list', () => {
-      const storageMock = createStorageMock(servers);
-      const service = new ServersService(storageMock);
+      const [ service, storageMock ] = createService();
 
       service.createServer({ id: 'ghi789' });
 
@@ -77,8 +77,7 @@ describe('ServersService', () => {
 
   describe('createServers', () => {
     it('adds multiple servers to the list', () => {
-      const storageMock = createStorageMock(servers);
-      const service = new ServersService(storageMock);
+      const [ service, storageMock ] = createService();
 
       service.createServers([{ id: 'ghi789' }, { id: 'jkl123' }]);
 
@@ -95,8 +94,7 @@ describe('ServersService', () => {
 
   describe('deleteServer', () => {
     it('removes one server from the list', () => {
-      const storageMock = createStorageMock(servers);
-      const service = new ServersService(storageMock);
+      const [ service, storageMock ] = createService();
 
       service.deleteServer({ id: 'abc123' });
 
@@ -107,4 +105,26 @@ describe('ServersService', () => {
       });
     });
   });
+
+  describe('editServer', () => {
+    it('dos nothing is provided server does not exist', () => {
+      const [ service, storageMock ] = createService();
+
+      service.editServer('notFound', {});
+
+      expect(storageMock.set).not.toHaveBeenCalled();
+    });
+
+    it('updates the list with provided server data', () => {
+      const [ service, storageMock ] = createService();
+      const serverData = { name: 'foo', apiKey: 'bar' };
+
+      service.editServer('abc123', serverData);
+
+      expect(storageMock.set).toHaveBeenCalledWith(expect.anything(), {
+        abc123: { id: 'abc123', ...serverData },
+        def456: { id: 'def456' },
+      });
+    });
+  });
 });