From 7e102c88cd053237415c4fc89c51f0ec075eb73b Mon Sep 17 00:00:00 2001 From: Devaev Maxim Date: Sun, 3 May 2020 06:17:43 +0300 Subject: [PATCH] log static errors as verbose --- src/http/static.c | 10 ++++++---- src/logging.h | 22 +++++++++++++++------- 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/src/http/static.c b/src/http/static.c index 0801799..90cc260 100644 --- a/src/http/static.c +++ b/src/http/static.c @@ -30,7 +30,7 @@ #include #include "../tools.h" -// #include "../logging.h" +#include "../logging.h" #include "path.h" @@ -42,6 +42,7 @@ char *find_static_file_path(const char *root_path, const char *request_path) { simplified_path = simplify_request_path(request_path); if (simplified_path[0] == '\0') { + LOG_VERBOSE("HTTP: Invalid request path %s to static", request_path); goto error; } @@ -50,13 +51,14 @@ char *find_static_file_path(const char *root_path, const char *request_path) { # define LOAD_STAT { \ if (lstat(path, &st) < 0) { \ - /* LOG_PERROR("Can't stat() file %s", path); */ \ + LOG_VERBOSE_PERROR("HTTP: Can't stat() static path %s", path); \ goto error; \ } \ } LOAD_STAT; if (S_ISDIR(st.st_mode)) { + LOG_VERBOSE("HTTP: Requested static path %s is a directory, trying %s/index.html", path, path); strcat(path, "/index.html"); LOAD_STAT; } @@ -64,12 +66,12 @@ char *find_static_file_path(const char *root_path, const char *request_path) { # undef LOAD_STAT if (!S_ISREG(st.st_mode)) { - // LOG_ERROR("Not a regulary file: %s", path); + LOG_VERBOSE("HTTP: Not a regular file: %s", path); goto error; } if (access(path, R_OK) < 0) { - // LOG_PERROR("Can't access() R_OK file %s", path); + LOG_VERBOSE_PERROR("HTTP: Can't access() R_OK file %s", path); goto error; } diff --git a/src/logging.h b/src/logging.h index 81c2e7e..eade908 100644 --- a/src/logging.h +++ b/src/logging.h @@ -88,14 +88,14 @@ pthread_mutex_t log_mutex; #define LOG_PRINTF_NOLOCK(_label_color, _label, _msg_color, _msg, ...) { \ - char _buf[MAX_THREAD_NAME] = {0}; \ - thread_get_name(_buf); \ + char _tname_buf[MAX_THREAD_NAME] = {0}; \ + thread_get_name(_tname_buf); \ if (log_colored) { \ printf(COLOR_GRAY "-- " _label_color _label COLOR_GRAY " [%.03Lf %9s]" " -- " COLOR_RESET _msg_color _msg COLOR_RESET, \ - get_now_monotonic(), _buf, ##__VA_ARGS__); \ + get_now_monotonic(), _tname_buf, ##__VA_ARGS__); \ } else { \ printf("-- " _label " [%.03Lf %9s] -- " _msg, \ - get_now_monotonic(), _buf, ##__VA_ARGS__); \ + get_now_monotonic(), _tname_buf, ##__VA_ARGS__); \ } \ putchar('\n'); \ fflush(stdout); \ @@ -112,9 +112,9 @@ pthread_mutex_t log_mutex; } #define LOG_PERROR(_msg, ...) { \ - char _buf[1024] = {0}; \ - char *_ptr = errno_to_string(_buf, 1024); \ - LOG_ERROR(_msg ": %s", ##__VA_ARGS__, _ptr); \ + char _perror_buf[1024] = {0}; \ + char *_perror_ptr = errno_to_string(_perror_buf, 1024); \ + LOG_ERROR(_msg ": %s", ##__VA_ARGS__, _perror_ptr); \ } #define LOG_INFO(_msg, ...) { \ @@ -143,6 +143,14 @@ pthread_mutex_t log_mutex; } \ } +#define LOG_VERBOSE_PERROR(_msg, ...) { \ + if (log_level >= LOG_LEVEL_VERBOSE) { \ + char _perror_buf[1024] = {0}; \ + char *_perror_ptr = errno_to_string(_perror_buf, 1024); \ + LOG_PRINTF(COLOR_BLUE, "VERB ", COLOR_BLUE, _msg ": %s", ##__VA_ARGS__, _perror_ptr); \ + } \ + } + #define LOG_DEBUG(_msg, ...) { \ if (log_level >= LOG_LEVEL_DEBUG) { \ LOG_PRINTF(COLOR_GRAY, "DEBUG", COLOR_GRAY, _msg, ##__VA_ARGS__); \