forked/topola-viewer
1
0
Fork 0
mirror of https://github.com/PeWu/topola-viewer.git synced 2026-03-10 17:43:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Speed up file processing by not initializing the comparator multiple times.

Browse Source
This commit is contained in:
Przemek Wiech
2019-03-20 00:07:16 +01:00
parent 3dbbba980a
commit 0e5c6181b9
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/gedcom_util.ts
View File

@@ -84,11 +84,14 @@ function birthDatesComparator(gedcom: JsonGedcomData) {
* Sorts children by birth date in the given family.
* Does not modify the input objects.
*/
function sortFamilyChildren(fam: JsonFam, gedcom: JsonGedcomData): JsonFam {
function sortFamilyChildren(
fam: JsonFam,
comparator: (id1: string, id2: string) => number,
): JsonFam {
if (!fam.children) {
return fam;
}
const newChildren = fam.children.sort(birthDatesComparator(gedcom));
const newChildren = fam.children.sort(comparator);
return Object.assign({}, fam, {children: newChildren});
}
@@ -97,7 +100,8 @@ function sortFamilyChildren(fam: JsonFam, gedcom: JsonGedcomData): JsonFam {
* Does not modify the input object.
*/
function sortChildren(gedcom: JsonGedcomData): JsonGedcomData {
const newFams = gedcom.fams.map((fam) => sortFamilyChildren(fam, gedcom));
const comparator = birthDatesComparator(gedcom);
const newFams = gedcom.fams.map((fam) => sortFamilyChildren(fam, comparator));
return Object.assign({}, gedcom, {fams: newFams});
}